fix(ember): Fix ember tests on release #2887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember-try uses npm to modify the package.json to test different versions of Ember, switching to use yarn should fix the issues it had resolving on new releases
k-fish
changed the title
Contributor
size-limit report
|
kamilogorek
force-pushed
the
fix/ember-test-on-release
branch
from
1277155 to
55a18f4
Compare
kamilogorek
force-pushed
the
fix/ember-test-on-release
branch
from
55a18f4 to
475537e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ember-try uses npm by default to modify the package.json to test different versions of Ember, switching to use yarn should fix the issues it had resolving on new releases.
Tested this on a branch locally by creating a new lerna version, so it should work now. Reverting the
disable ember testscommit.